phat code The number you have dialed is imaginary. Rotate phone 90 degrees and try again.
Main

Projects

Downloads

Articles

Links

Forum

 

View Message

Back to Messages
pr0gger from qbn Sun Jul 1 2007 at 11:29 pm
great software; I think I found a couple of bugs though.
 
 
First: nice little bit o' code you have here.  I'm usually not a fan of tree forums but this was the type of clean board I've been looking for (:

When I was playing with your code (v1.4) I came across possible bugs, maybe you'll want to look into them:

In index.php, on the Remove Messages screen, there's an unclosed DIV tag.

Line 1437, in the block to remove messages by IP:

print('<a...="'.php_self().' ?action=admin'.$sid.'&confirm=no">'.TEXT_N O.'</a></div>');

If I'm inferring correctly, that last tag closes the DIV that begins in line 1434.

Compare that to line 1535, in the block to remove messages using the checkboxes:

print('<a...="'.php_self().' ?action=admin'.$sid.'&confirm=no">'.TEXT_N O.'</a>');

I think line 1535 should be identical to line 1437, so you close the DIV that begins on line 1512...?

* * *

Also, in settings.php, line 89:

define('FORUM_HR', space(10).'<div align="center" style="width:100%;"><table cellpadding="0" cellspacing="0" width="100%"><tr><td class="forum_shade_hr"></td></tr>< /table></div></div>'.space(10).BR);

could be

define('FORUM_HR', space(10).'<div align="center" style="width:100%;"><table cellpadding="0" cellspacing="0" width="100%"><tr><td class="forum_shade_hr"></td></tr>< /table></div>'.space(10).BR);

or else you may be closing DIVs unintentionally.

--j_k/redtail/pr0gger
 
 
 
 

Reply to this Message

Name
Subject
Message

No HTML is allowed, except for <code> <b> <i> <u> in the message only.
All URLs and email addresses will automatically be converted to hyperlinks.